Make test-package-with-data a flat-layout package to restore skipped failing test#266
Merged
danyeaw merged 4 commits intoconda:mainfrom Mar 10, 2026
Conversation
Merging this PR will degrade performance by 30.39%
Performance Changes
Comparing 
Footnotes |
Member
|
Hi @agriyakhetarpal - do you think the codspeed performance decrease is expected? |
Contributor
Author
Hi @danyeaw, I don't think it is related. I can investigate it separately, but in the meantime, I've merged |
github-project-automation
bot
moved this to Sorting ⚙️
in conda Roadmap and Sprint Planning
Contributor
Author
|
Looks like other PRs also have the same CodSpeed regression, so we should be fine here. |
github-project-automation
bot
moved this from In review 🔍
to Done 💪🏾
in conda Roadmap and Sprint Planning
agriyakhetarpal
deleted the
undo-test_install_installer_data_files_present-skip
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This package has a src-layout and the
src/folder is gitignored, which is why the test was failing. I've changed it to a flat-layout package and added its files to the worktree with this PR. I tested this on my fork in agriyakhetarpal#1 as well, and CI is green.The other option is to continue having it as an src-layout package; I would not mind adding more specific rules to the gitignore file to adjust this. Please LMK!
Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?